Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquidator should be able to specify multiple rewards #1129

Closed
robert-zaremba opened this issue Jul 13, 2022 · 1 comment
Closed

Liquidator should be able to specify multiple rewards #1129

robert-zaremba opened this issue Jul 13, 2022 · 1 comment

Comments

@robert-zaremba
Copy link
Member

robert-zaremba commented Jul 13, 2022

Reward is a collateral denom a liquidator selects to receive when he liquidates an unhealthy borrow position.

Today, we only accept liquidation with only one selected reward. However, it may happen that liquidator has to select few collaterals to cover his repayment.

Example: Alice has the following tokens (in USD value) as a collateral: $100A, $200B, $500C. She borrows $1000X. After some time X market value drops and liquidation happens and we need to liquidate $400 of her collateral. Let's assume that value of A B and C was relatively stable (so we won't get into bad collateral discussion here). Liquidator will like to receive A, B and C in that order of preference. So, we need to change the MsgLiquidate:

repeated Coin reward = 4 [(gogoproto.nullable) = false];
@toteki
Copy link
Member

toteki commented Aug 31, 2022

I prefer we close this - since all the calculations (direct liquidation fee, prices, repayment amount, close factor, bad debt) would have to be chained like the two (or more) collateral liquidations were separate events, sending them in one message wouldn't add significant value. Liquidators can use separate transactions if one collateral type is exhausted.

@toteki toteki closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants