Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI commands should be less ambigous with respect to --from and sender #1205

Closed
robert-zaremba opened this issue Aug 3, 2022 · 0 comments · Fixed by #1333
Closed

CLI commands should be less ambigous with respect to --from and sender #1205

robert-zaremba opened this issue Aug 3, 2022 · 0 comments · Fixed by #1333

Comments

@robert-zaremba
Copy link
Member

Ref: #1118 (comment)

In the past we had few discussion on how to represent a sender in CLI with combination to --from flag. Traditional SDK CLI tx commands (eg tx bank send) use sender positional argument and overwrite it with --from. This creates a confusion for a use: which parameter takes the precedence? Which parameter is required.
It's simpler to do it in a one way and make sure it's correctly documented in CLI help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant