Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require passing a logger on every call #403

Open
fabianfett opened this issue Aug 28, 2023 · 1 comment
Open

Do not require passing a logger on every call #403

fabianfett opened this issue Aug 28, 2023 · 1 comment
Labels
breaking To fix this bug or implement this feature we must break API enhancement New feature or request
Milestone
2.0.0

Comments

@fabianfett
Copy link
Collaborator

Currently we require users to pass a Logger at every query call. We should change that behavior and provide a default NoOpLogger/ nil Logger instead.
@fabianfett fabianfett added the enhancement New feature or request label Aug 28, 2023
@fabianfett fabianfett added this to the 2.0.0 milestone Aug 28, 2023
@xjru
Copy link

xjru commented Nov 16, 2023 •
edited
Loading

That would be extremely welcome!

Why not use the logger that gets passed to connect?

@fabianfett fabianfett added the breaking To fix this bug or implement this feature we must break API label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking To fix this bug or implement this feature we must break API enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@xjru @fabianfett