Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please don't use anything *unsafe* #47

Closed
weissi opened this issue Aug 12, 2019 · 2 comments · Fixed by #48
Closed

please don't use anything *unsafe* #47

weissi opened this issue Aug 12, 2019 · 2 comments · Fixed by #48
Labels
bug Something isn't working

Comments

@weissi
Copy link
Contributor

weissi commented Aug 12, 2019

Code that contains the word *unsafe* is just as unsafe as C(++) code. In Swift there shouldn't be a necessity to use unsafe code unless we're interfacing with C(++).

Please file a NIO bug if there's anything that's not C(++) interop that you can't express without *unsafe*. See #46 , #45 , #44 for what happens with *unsafe* APIs.

@tanner0101 tanner0101 added the bug Something isn't working label Aug 12, 2019
@tanner0101
Copy link
Member

The only thing left in this package with unsafe is the getUUID method's usage of Swift.withUnsafeMutableBytes(of:). 👍

@weissi
Copy link
Contributor Author

weissi commented Aug 12, 2019

Thank you @tanner0101 for looking into this so quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants