-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConnectionPool crash on keepalive with non-empty request queue #472
Labels
bug
Something isn't working
Comments
lovetodream
changed the title
ConnectionPool crash on keepalive with non-empty reuest queue
ConnectionPool crash on keepalive with non-empty request queue
May 7, 2024
Thanks for the report! A couple of questions:
|
To q1, I do use Xcode 13.3, odd that it says 5.10-dev.
I did actually chat with Fabian a moment ago on Discord and we agreed that I'll create a test case for the crash and continue on from there with his guidance if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the issue
The connection pool crashes when a lot of requests occur in a burst
Vapor version
n/a
Operating system and version
macOS 14.4.1
Swift version
Swift Package Manager - Swift 5.10.0-dev
Steps to reproduce
Run the following script:
Outcome
A crash happens (typically on the start of the second burst, after running the script for approx. 1.5 min), the crash occurs in
PoolStateMachine.connectionKeepAliceTimerTriggered(_:)
due to a non-empty request queue. My assumption is, that there's a race condition when the timer triggers the ping and the next batch of requests is "inserted" into the pool.Additional notes
No response
The text was updated successfully, but these errors were encountered: