-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make script fails if no version number found #342
Comments
I'll be looking into this now :) |
@linus-hologram there's also #393 that could be good to finish off at the same time if you're interested |
@0xTim alright, i'll look into this too :) |
Also with this one, what work is left to do? What is the overall goal of this PR? Is there an issue it refers to? Kinda tapping in the dark what I'm supposed to do here... |
Just to have it here as well as Discord, #393 does not pass CI for some reason. I don't think it's related to this one, but if it is and you can merge them together then even better |
Thank you for making it possible to use the toolbox CLI without homebrew.
Defect
I found the problem: Your release .zip-file is not a git repository, so the
currentVersion()
function inscripts/build.swift
can not create a version number.In directory
toolbox-18.2.2
I used the following command.Workaround
Just clone the repository, do not use the release.
If you want to use the release you can just change the
scripts/build.swift
'scurrentVersion()
function to return the current version like the following code.Error message
Downloaded the release 18.2.2 and unzipped it.
Using Catalina 10.15.6 and Xcode 11.7 .
In directory
toolbox-18.2.2
I used the following commands.The text was updated successfully, but these errors were encountered: