Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imgui Implementation Comments #12

Open
utterances-bot opened this issue Sep 23, 2021 · 8 comments
Open

Imgui Implementation Comments #12

utterances-bot opened this issue Sep 23, 2021 · 8 comments

Comments

@utterances-bot
Copy link

Implementing DearImgui to a Vulkan engine - Vulkan Guide

Practical guide to vulkan graphics programming

https://www.vkguide.dev/docs/extra-chapter/implementing_imgui/

Copy link

Should use lastest ImGUI version to avoid strange 'Validation Error: [ VUID-VkMappedMemoryRange-size-01389 ]', please refer to this.

Copy link

This says to use in target_sources the files "${CMAKE_CURRENT_SOURCE_DIR}/imgui/imgui_impl_vulkan.cpp" and "${CMAKE_CURRENT_SOURCE_DIR}/imgui/imgui_impl_sdl.cpp". With the current imgui that should be "${CMAKE_CURRENT_SOURCE_DIR}/imgui/backends/imgui_impl_vulkan.cpp" and "${CMAKE_CURRENT_SOURCE_DIR}/imgui/backends/imgui_impl_sdl.cpp".

Copy link

Also, "${CMAKE_CURRENT_SOURCE_DIR}/imgui/imgui_tables.cpp" is missing.

Copy link

The CVAR page is missing a comment section. The CVarArray destructor uses the wrong delete, it should be: delete[] cvars;

Copy link

tuket commented Oct 24, 2022

Hello, Victor Blanco.
I have checked the code repo, but it looks like ImGui is not used there. Any chance you could upload that example code as well? I'm having trouble to get gamma color spaces right with ImGui, and I would like to see how you did it.
Thanks!

EDIT:
To anyone struggling to get gamma correction working with Vulkan+ImGui: https://tuket.github.io/posts/2022-11-24-imgui-gamma/

Copy link

What are the steps involved when using something other than SDL?

Copy link

I used to this guide to integrate imgui with my vulkan/glfw renderer and the steps are nearly the same

Copy link

is Dear ImGui compatible with VK_EXT_DESCRIPTOR_BUFFER as of now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants