-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta Docs: Metadata page incorrectly uses ReactDOM.preload() for <link rel="preconnect" /> example #48356
Comments
The function I think the documentation example file should probably look like this.
I wonder since we would render |
Good catch @GeorgeIpsum, I'll update the docs shortly. @Maroben these are relatively new React methods that haven't been documented yet, here's the PR: facebook/react#26237 |
I'm trying to use this, but PreloadResources seems unused. Do I need to import |
I see app router is still using tags for Next/Image prefetches. I assume it should be replace with ReactDOM.preload(). |
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
What is the improvement or update you wish to see?
On https://beta.nextjs.org/docs/api-reference/metadata#link-relpreconnect:
The example listed here used
ReactDOM.preload
instead ofReactDOM.preconnect
here. As far as I know, this is incorrect, but the appropriate function can just be swapped in. Super easy fix! (Didn't see where if possible to create a PR for beta docs changes)Is there any context that might help us understand?
This should be it
Does the docs page already exist? Please link to it.
https://beta.nextjs.org/docs/api-reference/metadata#link-relpreconnect
The text was updated successfully, but these errors were encountered: