Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move relay-controlled generator settings into device list #1335

Open
philipptrenz opened this issue Aug 20, 2024 · 1 comment
Open

Move relay-controlled generator settings into device list #1335

philipptrenz opened this issue Aug 20, 2024 · 1 comment
Assignees
Milestone

Comments

@philipptrenz
Copy link
Collaborator

philipptrenz commented Aug 20, 2024

As planned in the GUI-v2 settings redesign project, all devices should appear in the device list. For gensets, this is already the case for connected ones. But the pages for relay-controlled ones are still located in the settings as "Generator start/stop".

Bildschirmfoto 2024-08-20 um 13 19 28

Additionally, there is a function to track the generator state via a digital input using the "Generator" role. By this, a "Generator" will show up in the device list.

Bildschirmfoto 2024-08-20 um 13 20 02

To harmonize connected and relay-controlled gensets:

  • Also the relay-controlled one should be displayed in the device list as soon as relay 1 is configured to "Generator start/stop"
  • The device should be merged together with the one from the digital input "Generator" option to accurately display also the state within the same device representation

As it is planned to use the digital input for improving accumulated run time counters for relay-controlled gensets (see #337), these two issues should be synced to provide the best user experience.

@philipptrenz philipptrenz added this to the v3.50 milestone Aug 20, 2024
@philipptrenz
Copy link
Collaborator Author

@mpvader any objections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants