Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fragmentWithinToleranceTest #2782

Closed
itsjamie opened this issue Jun 4, 2020 · 1 comment
Closed

Refactor fragmentWithinToleranceTest #2782

itsjamie opened this issue Jun 4, 2020 · 1 comment
Labels
Enhancement

Comments

@itsjamie
Copy link
Collaborator

itsjamie commented Jun 4, 2020

The current algorithm is sensitive to small fragments that are common in ad conditioned content. Their short duration costs issues with the tolerance level due to the Math.min.

Originally posted by @itsjamie in #2777
@robwalch robwalch added the Chore label Jun 12, 2020
@stale stale bot added the Stale label Jul 3, 2020
@stale stale bot closed this as completed Jul 6, 2020
@robwalch robwalch added Enhancement and removed Stale labels Jul 6, 2020
@robwalch robwalch reopened this Jul 6, 2020
@video-dev video-dev deleted a comment from stale bot Jul 6, 2020
@video-dev video-dev deleted a comment from stale bot Jul 6, 2020
@robwalch
Copy link
Collaborator

While not a complete refactor, #5084 and earlier work that enforces segment loading order, should have addressed concerns behind this issue. If not, please provide a new bug report with repro steps.

@robwalch robwalch removed the Chore label Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robwalch @itsjamie