From da6980382309f4a41756ef1e36468b46135ae723 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Mon, 12 Feb 2024 10:45:05 +0100 Subject: [PATCH] Report invalid number of arguments for psalm-taint-* --- .../PhpVisitor/Reflector/FunctionLikeDocblockParser.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Psalm/Internal/PhpVisitor/Reflector/FunctionLikeDocblockParser.php b/src/Psalm/Internal/PhpVisitor/Reflector/FunctionLikeDocblockParser.php index e2a2cc5a14b..923313ec34b 100644 --- a/src/Psalm/Internal/PhpVisitor/Reflector/FunctionLikeDocblockParser.php +++ b/src/Psalm/Internal/PhpVisitor/Reflector/FunctionLikeDocblockParser.php @@ -238,6 +238,8 @@ public static function parse( if (count($param_parts) >= 2) { $info->taint_sink_params[] = ['name' => $param_parts[1], 'taint' => $param_parts[0]]; + } else { + throw new IncorrectDocblockException('@psalm-taint-sink expects 2 arguments'); } } } @@ -279,6 +281,8 @@ public static function parse( if ($param_parts[0]) { $info->taint_source_types[] = $param_parts[0]; + } else { + throw new IncorrectDocblockException('@psalm-taint-source expects 1 argument'); } } } elseif (isset($parsed_docblock->tags['return-taint'])) {