-
Notifications
You must be signed in to change notification settings - Fork 480
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [Bug] Block while shield sheathed. #2157
Comments
this should actually replace the code that prevents blocking AND parrying while casting, mounted, etc. |
https://warcraft.wiki.gg/wiki/Patch_2.1.0_(undocumented_changes) |
vid.2024-08-28-1423-34.mp4I can't reproduce it on classic. I don't have my shield or melee weapon drawn yet I can block and parry attacks. |
We'll assume the TBC patch notes to be true, and if someone finds video proof from vanilla of blocking without having shield drawn we'll revert it. |
Okay I performed a better test and I understood how it works. It's specifically in unarmed sheath state that you can't block. In ranged state you can still block. Also it does not affect parry. vid.2024-08-28-1454-05.mp4 |
🐛 Bug report
You can currently block with shield sheathed.
Expected behavior
On classic you have to have shield unsheathed, if you want to block a hit.
Any hit while your shield is not in your hand, will not be possible to block on classic.
The only thing I have from vanilla is from the spell attribute of the block spell in 1.12.1:
SPELL_ATTR_DO_NOT_SHEATH
It only exists in SpellDefines.h but nowhere else.
Steps to reproduce
Version & Environment
Client Version: 1.12.1.5875
Commit Hash: 4e9b446
OS Client: Windows 11 Pro N 10.0.22621.1413
OS Server: Windows 11 Pro N 10.0.22621.1413
Crashlog
The text was updated successfully, but these errors were encountered: