Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose moving volume claim validation&generate logic into admission hook #139

Closed
TommyLike opened this issue May 7, 2019 · 3 comments
Closed

Propose moving volume claim validation&generate logic into admission hook #139

TommyLike opened this issue May 7, 2019 · 3 comments
Assignees
@k82cn

Comments

@TommyLike
Copy link
Contributor

TommyLike commented May 7, 2019 •
edited
Loading

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

Now it's handled in job controller here which I think should be moved into admission hook, comment if there is something missing.

NOTE: hard to think of the case of conflict when generating new names. Since there are 12 random alphabets.
@TommyLike
Copy link
Contributor Author

/assign @k82cn

@k82cn
Copy link
Member

k82cn commented May 7, 2019

Since there are 12 random alphabets

We need to make sure that'll not happen in any case.

@TommyLike
Copy link
Contributor Author

give up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@k82cn k82cn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TommyLike @k82cn