Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Binpack for dominant resources #410

Closed
k82cn opened this issue Aug 12, 2019 · 11 comments
Closed

Enhance Binpack for dominant resources #410

k82cn opened this issue Aug 12, 2019 · 11 comments
Labels
area/scheduling kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@k82cn
Copy link
Member

k82cn commented Aug 12, 2019

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

Description:

In binpack plugin, we consider all resources almost equally (with weight); but there's a problem that the cpu/mem maybe exhausted but GPUs are idle, and those GPU can not be used because GPU apps also need some cpu/mem to run.

The solution in my mind is to also consider dominant resource of node; and the binpack plugin should consider the dominant resource of Pod and Node together.

@volcano-sh-bot volcano-sh-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 12, 2019
@k82cn
Copy link
Member Author

k82cn commented Aug 12, 2019

/area scheduling

@k82cn
Copy link
Member Author

k82cn commented Aug 12, 2019

/cc @lminzhw

@k82cn
Copy link
Member Author

k82cn commented Aug 12, 2019

/cc @hex108 @Jeffwan

@hzxuzhonghu
Copy link
Collaborator

Is #380 addressed this?

@lminzhw
Copy link
Contributor

lminzhw commented Aug 31, 2019

Is #380 addressed this?

No, #380 support the basic binpack policy, but the problem in this issue still exist.

@hzxuzhonghu hzxuzhonghu added this to the v0.3 milestone Aug 31, 2019
@jeffgx619
Copy link

Do we have any update for this ? We have the same use-case as well. Currently, we pre-reserve several CPU resources for GPUs.

@k82cn
Copy link
Member Author

k82cn commented Oct 24, 2019

Hope we can have this in 0.3; if you have any proposal, please feel free to share it :)

@k82cn k82cn removed this from the v0.3 milestone Nov 27, 2019
@stale
Copy link

stale bot commented Aug 18, 2020

Hello 👋 Looks like there was no activity on this issue for last 90 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@stale
Copy link

stale bot commented Oct 17, 2020

Closing for now as there was no activity for last 60 days after marked as stale, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Oct 17, 2020
@william-wang william-wang reopened this Feb 26, 2022
@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 26, 2022
@stale
Copy link

stale bot commented May 31, 2022

Hello 👋 Looks like there was no activity on this issue for last 90 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 31, 2022
@stale
Copy link

stale bot commented Aug 10, 2022

Closing for now as there was no activity for last 60 days after marked as stale, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scheduling kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

6 participants