diff --git a/packages/reactivity/__tests__/effect.spec.ts b/packages/reactivity/__tests__/effect.spec.ts index 925d9ed6104..9109177bf49 100644 --- a/packages/reactivity/__tests__/effect.spec.ts +++ b/packages/reactivity/__tests__/effect.spec.ts @@ -3,19 +3,16 @@ import { type ReactiveEffectRunner, TrackOpTypes, TriggerOpTypes, - computed, effect, markRaw, reactive, readonly, - ref, shallowReactive, stop, toRaw, } from '../src/index' import { pauseScheduling, resetScheduling } from '../src/effect' import { ITERATE_KEY, getDepFromReactive } from '../src/reactiveEffect' -import { h, nextTick, nodeOps, render, serialize } from '@vue/runtime-test' describe('reactivity/effect', () => { it('should run the passed function once (wrapped by a effect)', () => { @@ -1014,35 +1011,6 @@ describe('reactivity/effect', () => { expect(counterSpy).toHaveBeenCalledTimes(1) }) - // #10082 - it('should set dirtyLevel when effect is allowRecurse and is running', async () => { - const s = ref(0) - const n = computed(() => s.value + 1) - - const Child = { - setup() { - s.value++ - return () => n.value - }, - } - - const renderSpy = vi.fn() - const Parent = { - setup() { - return () => { - renderSpy() - return [n.value, h(Child)] - } - }, - } - - const root = nodeOps.createElement('div') - render(h(Parent), root) - await nextTick() - expect(serialize(root)).toBe('
22
') - expect(renderSpy).toHaveBeenCalledTimes(2) - }) - describe('empty dep cleanup', () => { it('should remove the dep when the effect is stopped', () => { const obj = reactive({ prop: 1 }) diff --git a/packages/reactivity/src/effect.ts b/packages/reactivity/src/effect.ts index 8876604bc7a..5ddf8e6f0ac 100644 --- a/packages/reactivity/src/effect.ts +++ b/packages/reactivity/src/effect.ts @@ -295,9 +295,7 @@ export function triggerEffects( } if ( effect._dirtyLevel < dirtyLevel && - (!effect._runnings || - effect.allowRecurse || - dirtyLevel !== DirtyLevels.ComputedValueDirty) + (!effect._runnings || dirtyLevel !== DirtyLevels.ComputedValueDirty) ) { const lastDirtyLevel = effect._dirtyLevel effect._dirtyLevel = dirtyLevel