Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default theme to support dark mode #29

Closed
jrappen opened this issue Jan 7, 2021 · 8 comments
Closed

Update default theme to support dark mode #29

jrappen opened this issue Jan 7, 2021 · 8 comments

Comments

@jrappen
Copy link

jrappen commented Jan 7, 2021

Feature request

Description

Please update the default theme to be dynamic, i.e. support dark mode.

Proposed Solution

This was the best I could find:

https://github.com/tolking/vuepress-theme-default-prefers-color-scheme

as I personally believe a dynamic theme shouldn't expose any manual toggles to the user.

@Mister-Hope
Copy link
Member

There are a lot of ways, e.g. https://vuepress-theme.mrhope.site/

@meteorlxy
Copy link
Member

Bumping to v2 is a good time point to support dark mode.

@Mister-Hope
Copy link
Member

I have a question, I saw the evergreen is set to true by default, and css var() is used in serveral plugins. So we are dropping IE support?

@tolking
Copy link

tolking commented Jan 16, 2021

@meteorlxy We can write CSS Variables for default theme, and the unsupported browsers by postcss plugIn. then support dark mode for supported browsers by prefers-color-scheme.

@tiziodcaio
Copy link

Does this feature request will applied?

@meteorlxy
Copy link
Member

@tiziodcaio It's listed in the Roadmap

@meteorlxy
Copy link
Member

I have a question, I saw the evergreen is set to true by default, and css var() is used in serveral plugins. So we are dropping IE support?

@Mister-Hope Now we can definitely say "YES" 😃

@tiziodcaio
Copy link

@tiziodcaio It's listed in the Roadmap

Woops... Sorry
So happy ☺️☺️☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants