Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIP: rename enum to flags #3642

Closed
charles-cooper opened this issue Oct 9, 2023 · 4 comments
Closed

VIP: rename enum to flags #3642

charles-cooper opened this issue Oct 9, 2023 · 4 comments
Milestone

Comments

@charles-cooper
Copy link
Member

Simple Summary

per title

Motivation

enum has been a bit confusing, since vyper's enum really follows https://docs.python.org/3/library/enum.html#enum.IntFlag semantics. rename to flags.

Specification

deprecate the enum keyword in 0.4.0, and support it as flags

optionally, introduce a non-flags enum type in 0.5.x series

Backwards Compatibility

All VIPs that introduce backwards incompatibilities must include a section describing these incompatibilities and their severity. The VIP must explain how the author proposes to deal with these incompatibilities.

Dependencies

If this VIP depends on any other VIPs being implemented, please mention them.

References

Add any references that this VIP might reference (other VIPs/issues, links to blog posts, etc.)

Copyright

Copyright and related rights waived via CC0

@charles-cooper charles-cooper added this to the v0.4.0 milestone Oct 9, 2023
@ControlCplusControlV
Copy link
Contributor

Will attempt to impl this and make a draft PR

@AlbertoCentonze
Copy link
Contributor

Hey @ControlCplusControlV do you mind if I take over this?

@ControlCplusControlV
Copy link
Contributor

Sure, go ahead!

@charles-cooper
Copy link
Member Author

implemented in #3697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants