Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble up revert errors for create built-ins #4147

Open
pcaversaccio opened this issue Jun 14, 2024 · 0 comments
Open

Bubble up revert errors for create built-ins #4147

pcaversaccio opened this issue Jun 14, 2024 · 0 comments
Labels

Comments

@pcaversaccio
Copy link
Collaborator

pcaversaccio commented Jun 14, 2024

I think on the (off-chain) tooling side it would be useful to have the possibility to enable bubbling up the revert reasons for the create built-ins such as create_minimal_proxy_to, create_copy_of, create_from_blueprint, and the planned raw_create built-in here. This means you could add a kwarg to these functions like raw_revert_data: uint256 = 0 and if it's above 0 the functions also return some return_data with Bytes[raw_revert_data] that can be processed further in case of a failure. If revert_on_failure is True, the called revert statement should be like raw_revert(return_data).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant