Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: keep browser_action and do not rename it to action #127

Closed
carlosjeurissen opened this issue Nov 1, 2021 · 2 comments
Closed
Labels
opposed: safari Opposed by Safari proposal Proposal for a change or new feature

Comments

@carlosjeurissen
Copy link
Contributor

A proposal was made and implemented in Chromium to rename browser_action to action in mv3. As the action is pretty much equivalent to browser_action it seems the name change thus doesn't make much sense.

My proposal here is to not rename browser_action and if needed treat action as alternative name for the API at least for mv3. This would allow other vendors to keep supporting page_action and would also prevent confusion with sidebar_action.

@xeenon
Copy link
Collaborator

xeenon commented Sep 1, 2022

I think the rename makes sense. Safari treats browser_action and page_action as the same in v2 already.

@carlosjeurissen
Copy link
Contributor Author

Since action is pretty much established and accepted, this proposal does not make sense anymore. Closing this as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
opposed: safari Opposed by Safari proposal Proposal for a change or new feature
Projects
None yet
Development

No branches or pull requests

2 participants