Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loss of followers and relays lists #4

Open
1 task done
wds4 opened this issue Jun 9, 2023 · 1 comment
Open
1 task done

Loss of followers and relays lists #4

wds4 opened this issue Jun 9, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@wds4
Copy link
Owner

wds4 commented Jun 9, 2023

Prerequisites

Expected Behavior

For any profile being managed in this app and simultaneously in one or more external apps, all profile details including relays and following lists should be synced at all times. That means that you can update your profile details, including relays list and following list, in the PGA app or externally, and your profile should sync immediately, everywhere it is located.

Current Behavior

Under certain situations you can inadvertently trigger loss of your following list and relays list.

Currently, syncing does not happen unless you activate a toggle button, which by default is turned off and which may currently be too well hidden, at least for new users.

Steps to reproduce

Enter privkey from external app, do NOT activate the option to sync your profile, and then follow someone. This will broadcast a kind: 3 event with a following list that is now empty (except for the profile you just followed). Updating your relays list using an unsynced profile will likely also trigger this same problem.

Potential Solutions

All of the following under consideration:

  • Set the sync option to "on" by default
  • Always sync by default. Get rid of the option not to sync a profile.
  • For any profile not created locally, disallow changing any profile details unless syncing is already turned on and has completed successfully at least once
  • Perhaps simply deactivate the ability to enter externally provided profiles. Or at least, display big flashy warnings of the danger.
  • Create the option to create a local profile and link it to your external profile in some manner. This may obviate the need to enter your externally derived profile in the first place.

My apologies to anyone who has encountered this error -- please let me know if this has happened to you and I will try to help you recover your lists!

@wds4 wds4 added the bug Something isn't working label Jun 9, 2023
@wds4
Copy link
Owner Author

wds4 commented Jun 14, 2023

In v0.1.2-alpha, the methods to address this problem are:

  • Set the sync option to "on" by default (you can still turn it off if you wish)
  • A warning is placed of the dangers of importing an externally-derived key, encouraging the user to make backups (although I don't currently offer a method of doing the backup)

Future releases will likely contain additional mitigations of this risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant