Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding Changelog #2

Open
rugk opened this issue Mar 29, 2024 · 4 comments
Open

Allow adding Changelog #2

rugk opened this issue Mar 29, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@rugk
Copy link
Contributor

rugk commented Mar 29, 2024

For a release, on AMO, you can manually upload a changelog (with a limited set of HTML), in different languages.

I e.g. maintain that data manually in .html files, like here: https://github.com/rugk/offline-qr-code/tree/master/assets/texts/en/Changelog

Maybe you can just allow a file path as input, which is then used as a changelog. (Maybe also a whole language directory, given how else may one automate that for all languages?)

@wdzeng wdzeng added the enhancement New feature or request label Apr 4, 2024
@wdzeng
Copy link
Owner

wdzeng commented Apr 4, 2024

Hi @rugk, did you mean the "Version Notes"?

image

@rugk
Copy link
Contributor Author

rugk commented Apr 4, 2024

Yes that's what I mean… it's kinda an oldish term 😉

@wdzeng
Copy link
Owner

wdzeng commented Apr 5, 2024

Hi @rugk, did you want to try v1.1.0-alpha.0?

steps:
  - uses: wdzeng/firefox-addon@v1.1.0-alpha.0
    with:
      addon-guid: your-addon's-guid
      xpi-path: your-addon.zip
      self-hosted: false
      release-notes: {"en-US":"foo"}
      jwt-issuer: ${{ secrets.FIREFOX_JWT_ISSUER }}
      jwt-secret: ${{ secrets.FIREFOX_JWT_SECRET }}

The release-notes accepts a JSON string. You will have to try to retrieve such value in the previous steps in the workflow. Thanks!

@rugk
Copy link
Contributor Author

rugk commented May 5, 2024

Hmm tried a draft, but first would need to find out how to read and all files in all localizations available… hmmpff… jaywcjlove/github-action-read-file#12

Edit: Tried something in rugk/mastodon-simplified-federation#127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants