Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pushing Docker images to GitHub image registry #2

Open
MLenterman opened this issue Jun 3, 2024 · 1 comment
Open

Support pushing Docker images to GitHub image registry #2

MLenterman opened this issue Jun 3, 2024 · 1 comment

Comments

@MLenterman
Copy link
Collaborator

Would be nice if the image registry target(GHCR, DockerHub) can be automatically selected based on the image-repo-name. For example:

  • image-repo-name "ghcr.io/wearefrank" would target GHCR
  • image-repo-name "docker.io/wearefrank" would target DockerHub
  • image-repo-name "wearefrank" would default to GHCR???

I think GHCR would make a more sensible default than DockerHub, because DockerHub always requires secrets to be configured, while GHCR can use the default GitHub provided GH_TOKEN/GITHUB_TOKEN if permission is configured in repo setting.

image-repo-name is used by multiple resuable workflows and GitHub actions in this ci-cd-templates repository. They currently specifically require the ghcr.io/docker.io prefix to NOT be included. Most of the work will be to change those workflows/actions to handle image-repo-name with a registry prefix.

@philipsens
Copy link
Member

I also think ghcr is more logical, because multiple people can manage the packages instead of only 3 (2 excluding the bot account).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants