Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Large responses break node clients using node-fetch #1345

Open
SgtPooki opened this issue May 20, 2022 · 1 comment
Open

Bug: Large responses break node clients using node-fetch #1345

SgtPooki opened this issue May 20, 2022 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up pi/psa-follow-up

Comments

@SgtPooki
Copy link

figured out multiple issues:

  1. web3.storage response times are high because you're sending back huge chunks of data that they don’t need to. (Check actual response data vs parsed response data in web3 pinning service returns invalid PinStatus object #1221 (comment))
  2. This causes node-fetch to fail silently when trying to response.text() regardless of try/catch blocks, .then(_, catchHandler), or even .catch() handlers.

Related to ipfs-shipyard/pinning-service-compliance#29

@SgtPooki SgtPooki added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels May 20, 2022
@SgtPooki
Copy link
Author

SgtPooki commented May 20, 2022

fixing item 1 is a breaking change for any existing users depending on that extra information, so to be fully compliant with the pinning service spec, you may need to stand up a different endpoint

@dchoi27 dchoi27 added pi/psa-follow-up P2 Medium: Good to have, but can wait until someone steps up and removed need/triage Needs initial labeling and prioritization labels May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up pi/psa-follow-up
Projects
None yet
Development

No branches or pull requests

2 participants