fix: memory leak when writeToDisk used (#472)

webpack · Sep 27, 2019 · 6730076 · 6730076
1 parent aec1bf7
commit 6730076
Show file tree

Hide file tree

Showing 4 changed files with 240 additions and 256 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -15,6 +15,10 @@ module.exports = {
 
     for (const compiler of compilers) {
       compiler.hooks.emit.tap('WebpackDevMiddleware', (compilation) => {
+        if (compiler.hasWebpackDevMiddlewareAssetEmittedCallback) {
+          return;
+        }
+
         compiler.hooks.assetEmitted.tapAsync(
           'WebpackDevMiddleware',
           (file, content, callback) => {
@@ -74,6 +78,7 @@ module.exports = {
             });
           }
         );
+        compiler.hasWebpackDevMiddlewareAssetEmittedCallback = true;
       });
     }
   },