-
-
Notifications
You must be signed in to change notification settings - Fork 377
-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
writeToDisk
leads the compile time keep increasing.
#469
Comments
Thanks for issue 👍 |
Looks like the |
@unbug yep, in my todo, will be fixed in near future |
@unbug hm, can you create minimum reproducible test repo? |
No need, find memory leak, WIP |
Is the memory leak you are talking about is that the first hook creates a new one on each pass, leading to never GC the I was myself investigating issues with webpack-dev-middleware and was about to submit a PR about this. (found it thanks to this clue: webpack/webpack#6929 (comment)). But I'm wondering if that would be useful to you reading your last comment. |
@JulienPradet yes, here same bug, on each compilation we create new callback on hook, so after 100 compilations we have 100 callbacks. Here memory leak. I added this to my todo list, try to throw warning on webpack side for webpack@5, it is allow catch all these cases. |
That would be awesome! |
@JulienPradet thanks, i am working on this right now, so I think there’s no point in working together on this, anyway thanks for feedback |
Expected Behavior
The compile-time should not keep increasing.
Actual Behavior
The compile-time keep increasing, and log shows duplicate write to disk keep increasing.
e.g. First compile:
Third compile:
Code
How Do We Reproduce?
I think to change the
logLevel
todebug
will see the log for any project.The text was updated successfully, but these errors were encountered: