Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close frame spanning multiple packets is not handled correctly #1493

Closed
1 task done
mwm-twx opened this issue Jan 23, 2019 · 0 comments
Closed
1 task done

Close frame spanning multiple packets is not handled correctly #1493

mwm-twx opened this issue Jan 23, 2019 · 0 comments

Comments

@mwm-twx
Copy link
Contributor

mwm-twx commented Jan 23, 2019

  • I've searched for any related issues and avoided creating a duplicate
    issue.

Description

A close frame which has been split over multiple TCP packets, for example

is not handled correctly. The payload is never read and conclude event not emitted.

Reproducible in:

  • version: 6.1.2
  • Node.js version(s): 10.12
  • OS version(s): Linux; Fedora 29

Steps to reproduce:

  1. Establish a websocket session

  2. Send a close frame from the server as two separate packets

Expected result:

  1. Close frame is parsed correctly and conclude event is emitted from receiver

Actual result:

  1. Close frame is not parsed and conclude is never emitted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant