Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket: only set cookies if WebSocket handshake succeeded #514

Open
annevk opened this issue Mar 24, 2017 · 0 comments
Open

WebSocket: only set cookies if WebSocket handshake succeeded #514

annevk opened this issue Mar 24, 2017 · 0 comments

Comments

@annevk
Copy link
Member

annevk commented Mar 24, 2017

See web-platform-tests/wpt#5213. This requires abstracting setting cookies somehow.

There's an additional question around cookies about at which point they are actually set and synchronized across "threads". A logical place for synchronization would be when Fetch queues a task that the response is in (all headers that is; though what about synchronous?) or when WebSocket establishes the connection and queues a task for that (it currently lets HTML deal with that, but maybe Fetch should take ownership).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant