Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum File size for quicklook #27

Closed
pehrlich opened this issue Oct 15, 2013 · 6 comments
Closed

Maximum File size for quicklook #27

pehrlich opened this issue Oct 15, 2013 · 6 comments

Comments

@pehrlich
Copy link

For example, I'll have an SQL dump file, and when arrow-keying through a folder, it will hang-up giving me the beachball until the entire file is able to be quicklooked. It would be great if this extension ignored files over a few kb.

@Marza
Copy link

Marza commented Oct 30, 2013

Or has a limit on how much to load. Could still be useful to see the first 50 lines of a large file instead of not seeing it at all. Limit would ofc be in size not rows as the first row could be the entire file of 50GB.

Would that be a ok solution @pehrlich ?

@uchuugaka
Copy link

Lines means nothing, that could only be based on newline characters. Focus on file size. If it is a text file that is super slow to load in QuickLook, it likely will be slow in most text editors as well.

@pehrlich
Copy link
Author

Sounds great to me.

@Marza
Copy link

Marza commented Oct 31, 2013

@uchuugaka sorry for mentioning lines at all.

Technically it would ofc be solved by just reading some amount of data, whatever it is and then display that.
The important thing for me is that I can see some content of the file which is possible atleast for text files to read some of the data and show that instead of reading the entire file. For some other file types that might not be possible and in that case we need to have that threshold and all filesizes above that are ignored.

@llamafilm
Copy link
Contributor

I agree, it would be a major help to use a maximum file size, perhaps 100KB or so. This extension causes the Finder to slow to a crawl when browsing around large non-text files.

@tsdorsey
Copy link
Collaborator

Released with 1.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants