-
Notifications
You must be signed in to change notification settings - Fork 492
Replace style-rules in tslint with prettier #77
Comments
I will accept a PR to implement this 👍 |
Would you consider using tslint-config-prettier? I'd be willing to submit the PR if no one else is already working on it. |
@corydeppen I don't believe anyone is working on this. Very happy to accept a PR 😄 |
It might be good to include this in the work @timjacobi is doing related to #109. Thoughts? |
Sounds good, check #112 |
@wmonk I think this can be closed now 🙂 |
Thanks! |
Hi, #281 included tslint-config-prettier, which turns off conflict tslint rule with prettier. However, that doesn't enable prettier code style. If we want to use prettier code style, we have to include tslint-plugin-prettier. @wmonk how do you think? I can make PR for this. |
@LucienLee: Enforcing this was not the intention of this change. Before it, the TSLint config contained a lot of rules related to opinionated code style, like ' vs ", of stuff about whitespacing. Some of these rules are also enabled by default when using one of the TSLint standard configurations. |
The reasons for not including style only eslint rules in create-react-app are also valid for this project.
As of 1.4 prettier supports TypeScript so that should be used for code style instead of tslint. The current tslint settings are incompatible with default prettier settings, which is the main reason I noticed this.
The text was updated successfully, but these errors were encountered: