Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

Replace style-rules in tslint with prettier #77

Closed
jacobrask opened this issue Jun 6, 2017 · 9 comments
Closed

Replace style-rules in tslint with prettier #77

jacobrask opened this issue Jun 6, 2017 · 9 comments

Comments

@jacobrask
Copy link

The reasons for not including style only eslint rules in create-react-app are also valid for this project.

As of 1.4 prettier supports TypeScript so that should be used for code style instead of tslint. The current tslint settings are incompatible with default prettier settings, which is the main reason I noticed this.

@wmonk
Copy link
Owner

wmonk commented Jun 13, 2017

I will accept a PR to implement this 👍

@corydeppen
Copy link

Would you consider using tslint-config-prettier? I'd be willing to submit the PR if no one else is already working on it.

@wmonk
Copy link
Owner

wmonk commented Aug 7, 2017

@corydeppen I don't believe anyone is working on this. Very happy to accept a PR 😄

@corydeppen
Copy link

It might be good to include this in the work @timjacobi is doing related to #109. Thoughts?

@wmonk
Copy link
Owner

wmonk commented Aug 7, 2017

Sounds good, check #112

@nielsdB97
Copy link
Contributor

nielsdB97 commented Mar 26, 2018

@wmonk I think this can be closed now 🙂

@wmonk
Copy link
Owner

wmonk commented Mar 26, 2018

Thanks!

@wmonk wmonk closed this as completed Mar 26, 2018
@LucienLee
Copy link

Hi, #281 included tslint-config-prettier, which turns off conflict tslint rule with prettier. However, that doesn't enable prettier code style. If we want to use prettier code style, we have to include tslint-plugin-prettier.

@wmonk how do you think? I can make PR for this.

@DorianGrey
Copy link
Collaborator

@LucienLee: Enforcing this was not the intention of this change. Before it, the TSLint config contained a lot of rules related to opinionated code style, like ' vs ", of stuff about whitespacing. Some of these rules are also enabled by default when using one of the TSLint standard configurations.
The intention was to kick style related rules from the config, e.g. for using tools like prettier to format the code automatically. And that config package does a good job for achieving this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants