Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use when keyword for pipeline conditions #283

Closed
anbraten opened this issue Aug 29, 2021 · 1 comment · Fixed by #770
Closed

Use when keyword for pipeline conditions #283

anbraten opened this issue Aug 29, 2021 · 1 comment · Fixed by #770
Labels
feature add new functionality pipeline-config related to pipeline config files (.yaml)
Milestone

Comments

@anbraten
Copy link
Member

Currently there is a single condition for whole pipeline files named branches. As woodpecker will probably support more conditions in the future like #86 and to match the way conditions for pipeline-steps are working it would be nice to move the branch condition below the when keyword.

pipeline:
  build:
    image: golang
    commands:
      - go build
      - go test
   when:
     branch: [master, develop]

-branches: [ master, develop ]
+when:
+  branch: [master, develop]
@anbraten anbraten added feature add new functionality pipeline-config related to pipeline config files (.yaml) labels Sep 16, 2021
@6543
Copy link
Member

6543 commented Sep 21, 2021

yes we should unify the when filter for pipeline and steps ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature add new functionality pipeline-config related to pipeline config files (.yaml)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants