Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error on manual run when connection with Forge lost #3943

Closed
3 tasks done
zc-devs opened this issue Jul 19, 2024 · 1 comment · Fixed by #3944 or #3981
Closed
3 tasks done

Improve error on manual run when connection with Forge lost #3943

zc-devs opened this issue Jul 19, 2024 · 1 comment · Fixed by #3944 or #3981
Labels
bug Something isn't working

Comments

@zc-devs
Copy link
Contributor

zc-devs commented Jul 19, 2024

Component

server

Describe the bug

If connection broken while you are running pipeline manually, you'll get unknown error and panic on Server.

Steps to reproduce

  1. Run Forge
  2. Run Woodpecker server, log in
  3. Open some repository
  4. Click Run pipeline
  5. Turn off Forge / scale down to 0 / disallow WP-Forge connection via firewall
  6. Close Trigger a manual pipeline run dialog by pressing Run pipeline button
  7. See unknown error and not closed overlay
    Error
  8. Check server logs and find panic recovered
    server-panic.log

Expected behavior

  1. Should not be panic on server
  2. As dialog closes, overlay should disappear also
  3. More meaningful error than unknown

System Info

`2.7.0`, Gitea

Additional context

No response

Validations

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
@zc-devs zc-devs added the bug Something isn't working label Jul 19, 2024
@zc-devs
Copy link
Contributor Author

zc-devs commented Jul 23, 2024

next-bbdeb4622c

While Should not be panic on server was fixed,

As dialog closes, overlay should disappear also
More meaningful error than unknown

are not addressed. Still unknown error (HTTP 500) and overlay doesn't close automatically.

@qwerty287 qwerty287 reopened this Jul 23, 2024
@qwerty287 qwerty287 changed the title Panic on manual run when connection with Forge lost Improve error on manual run when connection with Forge lost Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants