Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate from github.com/woodpecker-ci/envsubst #429

Closed
6543 opened this issue Oct 10, 2021 · 2 comments
Closed

migrate from github.com/woodpecker-ci/envsubst #429

6543 opened this issue Oct 10, 2021 · 2 comments
Labels
hacktoberfest-accepted refactor delete or replace old code
Milestone
0.15.0

Comments

@6543
Copy link
Member

6543 commented Oct 10, 2021 •
edited
Loading

woodpecker/cli/exec/exec.go

Line 14 in 9c85c8f

"github.com/drone/envsubst"

Originally posted by @6543 in #426 (comment)
@6543 6543 added the refactor delete or replace old code label Oct 10, 2021
@6543 6543 added this to the 0.15.0 milestone Oct 10, 2021
@jolheiser
Copy link
Member

Does this need to be done? Currently drone/envsubst is MIT and has commits from July.

@6543
Copy link
Member Author

6543 commented Oct 12, 2021

hmm you are right ... let's let it maintain upstream and only if we have patches who do not make it upstream we could reconsider this.

since we have a fork and do vendoring I think there is nothing we have to worry :)

@6543 6543 closed this as completed Oct 12, 2021
@6543 6543 mentioned this issue Oct 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest-accepted refactor delete or replace old code
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
2 participants
@6543 @jolheiser