Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT datalogging converts "int" typestring to "int64", but not "int[]" to "int64[]" #6203

Closed
shueja opened this issue Jan 11, 2024 · 0 comments · Fixed by #6279
Closed

NT datalogging converts "int" typestring to "int64", but not "int[]" to "int64[]" #6203

shueja opened this issue Jan 11, 2024 · 0 comments · Fixed by #6279

Comments

@shueja
Copy link
Contributor

shueja commented Jan 11, 2024

https://github.com/wpilibsuite/allwpilib/blob/ba9c21cf3889014655d2baee61340449cb1fff05/ntcore/src/main/native/cpp/LocalStorage.cpp#L51C25-L51C25

The above line of code is used to convert the typestring of a NT entry into that of a DataLog entry. It converts the "int" typestring to "int64", but not "int[]" to "int64[]". This means that NT's auto-datalogging will log to a given path with a type "int[]", while an IntegerArrayLogEntry will log with "int64[]". This is a type mismatch and leads to the logging being ignored if it does not match the typestring used when first logging to the path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant