Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional User's Proxy for the atomicMatch #80

Open
ssnar opened this issue Apr 22, 2022 · 0 comments
Open

Optional User's Proxy for the atomicMatch #80

ssnar opened this issue Apr 22, 2022 · 0 comments

Comments

@ssnar
Copy link

ssnar commented Apr 22, 2022

From what i understood, in order to do any exchange (atomicMatch) the taker & maker (buyer & seller) must have the proxy registered in the ProxyRegistry.

In the case of doing NFT ERC20 trade, we might not require the buyer (the one who will send erc20) to have the proxy & do the approval of ERC20 to the proxy. Instead, we might just use the tokenTransferProxy and then only approve the ERC20 to that tokenTransferProxy (similar like what in wyvern v2 did), so the buyer doesn't require to register the proxy first which causes additional gas fee.

Is there any workaround how to solve this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant