Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix or remove grcov-coverage CI job #3394

Closed
shssoichiro opened this issue Aug 14, 2024 · 1 comment · Fixed by #3398
Closed

Fix or remove grcov-coverage CI job #3394

shssoichiro opened this issue Aug 14, 2024 · 1 comment · Fixed by #3398
Labels
CI CI Related issues

Comments

@shssoichiro
Copy link
Collaborator

The CI job for code coverage has been broken for quite some time. It is allowed to fail, but still annoying to show as a red X on every PR. We should either fix the job or remove it.

Example: https://github.com/xiph/rav1e/actions/runs/10392532069/job/28780308261
@shssoichiro shssoichiro added bug CI CI Related issues and removed bug labels Aug 14, 2024
@FreezyLemon
Copy link
Contributor

Maybe exclude the binary tests from codecov? Seems like it's only those that are failing, and those don't contribute to coverage stats anyways, right?

@FreezyLemon FreezyLemon mentioned this issue Sep 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI CI Related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop binary integration test from coverage FreezyLemon/rav1e
2 participants
@shssoichiro @FreezyLemon