Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the progress is at 0, the label doesn't show up #48

Open
jlubeck opened this issue Nov 21, 2016 · 3 comments
Open

When the progress is at 0, the label doesn't show up #48

jlubeck opened this issue Nov 21, 2016 · 3 comments

Comments

@jlubeck
Copy link

jlubeck commented Nov 21, 2016

It looks like for some reason with a 0% label, it doesn't show up. But it would be nice to have it, as otherwise it looks like the bar is broken or something...

Thank you

@yannickl
Copy link
Owner

Which indicatorTextDisplayMode are you using?

Have you tried with YLProgressBarIndicatorTextDisplayModeFixedRight or YLProgressBarIndicatorTextDisplayModeFixedLeft?

@jlubeck
Copy link
Author

jlubeck commented Nov 24, 2016

YLProgressBarIndicatorTextDisplayModeProgress

Haven't tried the others one, as having the text go with the progress looks the best. Isn´t it possible to have it behave as it is, but when it´s close to the left, just fix it so it's still seen?

Where should I check in the code to try and do it myself and maybe do a pull request?

Thanks!

@yannickl
Copy link
Owner

An issue can occurred if the text color and the background's track have a low contrast ratio.

To avoid breaking the current behaviour you should create a new YLProgressBarIndicatorTextDisplayMode.

And then managing the display here and may be in the drawText:withRect:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants