Broaden changes to include factories?

[nathany]

I came across a factory that needed to be updated:

-before(:create) {|a| a.stub(:attach_work_configuration) }
-after(:create) {|a| a.unstub(:attach_work_configuration) }
+before(:create) {|a| allow(a).to receive(:attach_work_configuration) }
+after(:create) {|a| allow(a).to receive(:attach_work_configuration).and_call_original }

Easy enough to handle manually or run transpec with a folder. Just thought I'd let you know.

# transpec 2.3.2
# ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-darwin13.0]

transpec --convert example_group,hook_scope

[yujinakayama]

Did you really rewrite it to allow(a)to ... by hand and run it? Actually, in the factory_girl's after callback block, the self is an instance of FactoryGirl::SyntaxRunner so RSpec's allow is unavailable there (see Inconvertible Specs in the README).

Also, it's already warned by Transpec:

# spec/factories.rb
FactoryGirl.define do
  factory :book do
    after(:create) do |book|
      book.stub(:foo)
    end
  end
end

$ transpec
...
Converting spec/factories.rb
Cannot convert #stub into #allow since #allow is not available in the context.
spec/factories.rb:5:      book.stub(:foo)

By the way, if you had an error while running transpec with the factory_girl's after callback, I've fixed it now and released 2.3.3. See #66 for the details.

[nathany]

Sorry, it looks like I failed to run the spec.

Is it even possible to include or extend RSpec::Matchers in the context of FactoryGirl?

I'd like to disable all the old syntax if possible.

[yujinakayama]

You can, by including RSpec::Mocks::ExampleMethods (allow is not in RSpec::Matchers) into FactoryGirl::SyntaxRunner:

# In spec_helper.rb or somewhere
FactoryGirl::SyntaxRunner.send(:include, RSpec::Mocks::ExampleMethods)

However, I think this isn't a well-mannered way since FactoryGirl::SyntaxRunner is marked as a private API.

Personally I don't use factory_girl much so I'm not sure that stubbing in the after(:create) callback is a right way and whether there's a good alternative way. If it's unavoidable, I think you should submit a feature request to factory_girl project.

[yujinakayama]

Closing since Transpec can do nothing with this.

[nathany]

Thanks @yujinakayama.