Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: -fast-highlight-xxx appear in builtin command completion #35

Open
2 of 3 tasks
Thearas opened this issue Feb 21, 2023 · 3 comments
Open
2 of 3 tasks

[bug]: -fast-highlight-xxx appear in builtin command completion #35

Thearas opened this issue Feb 21, 2023 · 3 comments
Assignees
Labels
bug 🐞 Inconsistencies or issues which will cause a problem for users or implementors. stale 👻 No activity for quite some time.

Comments

@Thearas
Copy link

Thearas commented Feb 21, 2023

Environment

OSTYPE=darwin21.3.0 CPUTYPE=arm64 / MACHINE_TYPE=arm ZSH_VERSION=5.9

Expected behavior

Press <tab> and show nothing:

time -<tab>

Current behavior

>  time -
-                                      -fast-highlight-fill-option-variables  -fast-highlight-process
-fast-highlight-check-path             -fast-highlight-init                   -fast-highlight-string
-fast-highlight-check-path-handler     -fast-highlight-main-type              -fast-highlight-string-process
-fast-highlight-dollar-string          -fast-highlight-math-string            -fsh_sy_h_shappend

Steps to reproduce

time -<tab>

Code snippet

I use oh-my-zsh:

plugins=(... F-Sy-H)

Aditional information

None.

Self-service

  • I'd be willing to address this documentation request myself.

Have you read the Contributing Guidelines?

Are you familiar with Contributor Covenant Code of Conduct?

Contact Details

No response

@Thearas Thearas added bug 🐞 Inconsistencies or issues which will cause a problem for users or implementors. triage 📑 The issue is awaiting investigation. labels Feb 21, 2023
@ss-o
Copy link
Member

ss-o commented Feb 22, 2023

Hi @Thearas,

Only -fast* appears and nothing else like: time .TAB or time _TAB ? 💫

@ss-o ss-o self-assigned this Feb 22, 2023
@Thearas
Copy link
Author

Thearas commented Feb 22, 2023

Hi @Thearas,

Only -fast* appears and nothing else like: time .TAB or time _TAB ? 💫

time .<TAB>:

image

time _<TAB>, but I think this is normal, some zsh functions like _precommand:
image

@ss-o
Copy link
Member

ss-o commented Feb 22, 2023

The same applies to F-Sy-H functions, the prefixes different than _ are chosen to describe/filter functions using #standard-function-name-space-prefixes.

However, it might be improved or contain accidentally exposed functions, both cases require investigation.

Is the - prefix causing any unwanted behavior?

Note: it is also possible to adjust the completion system, the suggested command (time) completion allows to time functions, which is why it appears in the completion.

@ss-o ss-o added stale 👻 No activity for quite some time. and removed triage 📑 The issue is awaiting investigation. labels Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Inconsistencies or issues which will cause a problem for users or implementors. stale 👻 No activity for quite some time.
Projects
None yet
Development

No branches or pull requests

2 participants