Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow to check if running go mod tidy changes go mod file #2961

Open
AustinAbro321 opened this issue Sep 3, 2024 · 0 comments · May be fixed by #2963
Open

Add workflow to check if running go mod tidy changes go mod file #2961

AustinAbro321 opened this issue Sep 3, 2024 · 0 comments · May be fixed by #2963
Assignees
@AustinAbro321
Labels
tech-debt 💳 Debt that the team has charged and needs to repay
Milestone
v0.40.0

Comments

@AustinAbro321
Copy link
Contributor

AustinAbro321 commented Sep 3, 2024 •
edited
Loading

Describe what should be investigated or refactored

We should introduce a workflow that fails if a PR introduces git changes when go mod tidy is run. This will force the creator to run go mod tidy locally and push. This is similar to the check-docs-and-schema workflow.

Additional context

The go.mod of the latest commit on main changes when go mod tidy is run
@AustinAbro321 AustinAbro321 added the tech-debt 💳 Debt that the team has charged and needs to repay label Sep 3, 2024
@AustinAbro321 AustinAbro321 changed the title Add workflow to check if go mod tidy introduces changes on PR Add workflow to check if go mod tidy changes go mod file Sep 3, 2024
@AustinAbro321 AustinAbro321 changed the title Add workflow to check if go mod tidy changes go mod file Add workflow to check if running go mod tidy changes go mod file Sep 3, 2024
@AustinAbro321 AustinAbro321 linked a pull request Sep 3, 2024 that will close this issue
Open
2 tasks
@salaxander salaxander added this to the v0.39.0 milestone Sep 4, 2024
@salaxander salaxander modified the milestones: v0.39.0, v0.40.0 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AustinAbro321 AustinAbro321

Labels
tech-debt 💳 Debt that the team has charged and needs to repay
Projects
Zarf
Status: In review
Milestone
v0.40.0
Development

Successfully merging a pull request may close this issue.

chore: workflow to check that go mod tidy is run zarf-dev/zarf
2 participants
@salaxander @AustinAbro321