New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add whitelist mechanism for the new ERC20CustodyContract #295

Closed

lumtis opened this issue Aug 7, 2024 · 0 comments · Fixed by #296

Assignees

Labels

evm v2

Member

lumtis commented Aug 7, 2024

Same as V1, we should for now have a whitelist system for the ERC20s.

The architecture should be similar to v1 except:

We should use a WHITELISTER_ROLE for Access Control. To add more flexibility and also grant Admin to whitelister role in addition to the TSS (as for the migration we will manually whitelist token instead of using admin message sending through TSS)
For simplicity WHITELISTER_ROLE can both whitelist and unwhitelist
Whitelisting should be checked in transferFromToAssetHandler in the gateway contract

lumtis added evm v2 labels

skosito self-assigned this

skosito linked a pull request

that will close this issue

feat: add whitelisting to erc20 custody v2 #296

Merged

skosito closed this as completed in #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment