From 1187c47b3fba419f7b6954121b359cdaabf3bab4 Mon Sep 17 00:00:00 2001 From: Techatrix Date: Sun, 11 Aug 2024 08:57:59 +0200 Subject: [PATCH] fix builtin completions after variable decl type specifier fixes #1992 --- src/analysis.zig | 5 +---- tests/utility/position_context.zig | 31 ++++++++++++++++++++++++++++++ 2 files changed, 32 insertions(+), 4 deletions(-) diff --git a/src/analysis.zig b/src/analysis.zig index 93db980d9..6d38c10e6 100644 --- a/src/analysis.zig +++ b/src/analysis.zig @@ -3528,10 +3528,7 @@ pub fn getPositionContext( }, else => {}, }, - .builtin => switch (curr_ctx.ctx) { - .empty, .pre_label => curr_ctx.ctx = .{ .builtin = tok.loc }, - else => {}, - }, + .builtin => curr_ctx.ctx = .{ .builtin = tok.loc }, .period, .period_asterisk => switch (curr_ctx.ctx) { .empty, .pre_label => curr_ctx.ctx = .{ .enum_literal = tok.loc }, .enum_literal => curr_ctx.ctx = .empty, diff --git a/tests/utility/position_context.zig b/tests/utility/position_context.zig index cb923bcc1..619343cbd 100644 --- a/tests/utility/position_context.zig +++ b/tests/utility/position_context.zig @@ -290,6 +290,37 @@ test "builtin" { "@intC", ); + try testContext( + \\var foo: @ + , + .empty, + null, + ); + try testContext( + \\var foo: @Thi(); + , + .builtin, + "@Thi", + ); + try testContext( + \\var foo: @Thi(); + , + .builtin, + "@Thi", + ); + try testContext( + \\var foo: @Thi(); + , + .builtin, + "@Thi", + ); + try testContext( + \\var foo: @Thi(); + , + .builtin, + "@Thi", + ); + try testContext( \\fn foo() void { @setRuntime(false); }; ,