Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken cross-file references #1071

Open
SuperAuguste opened this issue Mar 16, 2023 · 1 comment
Open

Broken cross-file references #1071

SuperAuguste opened this issue Mar 16, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@SuperAuguste
Copy link
Member

references.zig uses DocumentStore.collectDependencies which collects the imports a file specifies; this incorrect - we should be collecting dependents (files that import the current file), not dependencies (files that the current file imports).

To take this on you'd have to create a new collectDependents function that loads in all files in a workspace while checking for imports and returns all files that import the current file.

@SuperAuguste SuperAuguste added bug Something isn't working good first issue Good for newcomers labels Mar 16, 2023
@Jarred-Sumner
Copy link
Contributor

Yes I think this is what I meant with this issue: #1070

After a recent change, an import 3-4 levels deep through usingnamespace stops working

https://github.com/oven-sh/bun/blob/6f59bc7d2e7aa64956bdd6f56769467853fd0242/src/main.zig#L45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants