Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign of junctions will not print correctly #128

Open
zachparrott opened this issue Jul 25, 2022 · 1 comment
Open

Sign of junctions will not print correctly #128

zachparrott opened this issue Jul 25, 2022 · 1 comment

Comments

@zachparrott
Copy link
Contributor

Noticed this with the recent fix of the calc_current_using_line_voltage, _Smj will always return true, need > 0 to get it to correctly print "(-)" when appropriate.

Currently:

f'\t{j_name:<15} {pmj_ind:>8.6g}{("(+)"if _Smj else "(-)"):>5s} {pmj_cap:>8.6g}')

Should change to something like:
f'\t{j_name:<15} {pmj_ind:>8.6g}{("(+)"if _Smj > 0 else "(-)"):>5s} {pmj_cap:>8.6g}')

@github-actions
Copy link

👏👏👏 You are awesome! Thank you for making your first issue to pyEPR ' first issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant