Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Ant 3.16.2 #59

Open
davidpanzarella opened this issue Apr 5, 2019 · 7 comments
Open

Update to Ant 3.16.2 #59

davidpanzarella opened this issue Apr 5, 2019 · 7 comments

Comments

@davidpanzarella
Copy link

Any chance you can pull in the latest Ant version?

@davidpanzarella davidpanzarella changed the title Update to Ant 3.16.1 Update to Ant 3.16.2 Apr 8, 2019
@mrlubos
Copy link
Contributor

mrlubos commented May 5, 2019

Hi @davidpanzarella, we've tried it and it introduced some breaking style changes that required further modifications in our component styling, so we decided not to do that for the time being. Have you tested this version without any issues?

@davidpanzarella
Copy link
Author

I haven't tested it, but we're on the latest Ant build in our app, and notice issues with this library. Doesn't seem to be very active, so we'll likely forgo using it.

@mrlubos
Copy link
Contributor

mrlubos commented May 6, 2019

@davidpanzarella Can you please describe what issues you're seeing? Thanks!

@davidpanzarella
Copy link
Author

Hi @mrlubos, we're mainly seeing issues with consistency. Some styles are not getting pulled in when including components from this library, which are likely due to the version of ant used in this version of redux-form-antd.

@zmitry
Copy link
Owner

zmitry commented May 27, 2019

But library has only peer dependency of antd, what its the problem?

@davidpanzarella
Copy link
Author

davidpanzarella commented May 27, 2019

The first issue is that not all the styles get imported. Take an example like this:

        <Field
            name="ShortDescription"
            component={TextAreaField}
            label="Short Description"
            placeholder="My Awesome Project"
            validate={
              [
                required({ message: 'Short description is required' }),
                length({ min: 20, message: 'Short description must be at least 20 characters' }),
                length({ max: 200, message: 'Short description must be less than 200 characters' })
              ]
            }
          />

Doing the above should work by just doing this
import { TextAreaField } from 'redux-form-antd';

However, no styles will get included unless I also import Input from antd, and also pull out TextArea from Input.
Eg. const { TextArea } = Input; // required to get styles to work with antdreduxform

Other issues I've seen also have to do with getting the number counter to work in an InputNumber, as well as, the styling Ant feedback for things like error messages and other error feedback. Like so:

Screen Shot 2019-05-27 at 12 44 12 PM

@kilya11
Copy link

kilya11 commented Aug 19, 2019

Would it be enough to import the style?

import 'antd/lib/input/style';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants