-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Ed25519 #51
Comments
No, I think that the we should enable that by default because otherwise we do not meet the expectations of the test case. In the installation instructions in Zonemaster-Engine we must include installation of new version of OpenSSL. |
It seems the update to OpenSSL 1.1.1 is not straight forward. And, it is not in our ability to add the installation instructions. I would rather define this issue as an upgrade, rather than a bug. |
It is a bug because the specifications says that we can test that. We can change the Test Case or change the code (and instructions) to remove the bug. |
Fall back to checking openssl version number. |
The bug is also covered by #84. |
PR #85 will resolve this issue. |
@matsduf why the issue is not closed? |
@sandoche2k I forgot to close it. |
Add support for algo 15, a.k.a. Ed25519. This is done by enabling a build time feature switch in
ldns
(--enable-ed25519
). When this switch is enabledldns
relies onlibssl
to provide APIs for Ed25519. If those APIs aren't available the ldns configure script simply prints a little warning and continues without Ed25519 support.Add a switch to Makefile.PL to explicitly control Ed25519 support. The feature should be enabled by default. If the feature is enabled but Ed25519 is unavailable, the build should fail.
This was originally reported in dotse/zonemaster#575.
Edit: I originally claimed that the build fails if Ed25519 support is requested when libssl doesn't support it. I can't reproduce that behavior anymore. Must have done something wrong but now I can't figure out what.
Edit 2: I updated the requirements for the feature switch in response to @matsduf's comment.
The text was updated successfully, but these errors were encountered: