Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Ed25519 #51

Closed
mattias-p opened this issue Mar 29, 2018 · 8 comments
Closed

Support for Ed25519 #51

mattias-p opened this issue Mar 29, 2018 · 8 comments
Assignees
Labels
P-High Priority: Issue to be solved before other T-Bug Type: Bug in software or error in test case description
Milestone

Comments

@mattias-p
Copy link
Member

mattias-p commented Mar 29, 2018

Add support for algo 15, a.k.a. Ed25519. This is done by enabling a build time feature switch in ldns (--enable-ed25519). When this switch is enabled ldns relies on libssl to provide APIs for Ed25519. If those APIs aren't available the ldns configure script simply prints a little warning and continues without Ed25519 support.

Add a switch to Makefile.PL to explicitly control Ed25519 support. The feature should be enabled by default. If the feature is enabled but Ed25519 is unavailable, the build should fail.

This was originally reported in dotse/zonemaster#575.

Edit: I originally claimed that the build fails if Ed25519 support is requested when libssl doesn't support it. I can't reproduce that behavior anymore. Must have done something wrong but now I can't figure out what.
Edit 2: I updated the requirements for the feature switch in response to @matsduf's comment.

@matsduf
Copy link
Contributor

matsduf commented Mar 29, 2018

No, I think that the we should enable that by default because otherwise we do not meet the expectations of the test case. In the installation instructions in Zonemaster-Engine we must include installation of new version of OpenSSL.

@matsduf matsduf added the T-Bug Type: Bug in software or error in test case description label Mar 29, 2018
@mattias-p mattias-p self-assigned this Mar 29, 2018
@sandoche2k
Copy link

It seems the update to OpenSSL 1.1.1 is not straight forward. And, it is not in our ability to add the installation instructions.

I would rather define this issue as an upgrade, rather than a bug.

@matsduf
Copy link
Contributor

matsduf commented Apr 3, 2018

It is a bug because the specifications says that we can test that. We can change the Test Case or change the code (and instructions) to remove the bug.

@mattias-p
Copy link
Member Author

Fall back to checking openssl version number.

@sandoche2k sandoche2k added this to the v2018.1 milestone Apr 12, 2018
@sandoche2k sandoche2k modified the milestones: v2018.1, v2018.2 Apr 23, 2018
@sandoche2k sandoche2k modified the milestones: v2018.2, v2019.2 Mar 13, 2019
@sandoche2k sandoche2k added the P-High Priority: Issue to be solved before other label Mar 13, 2019
@matsduf
Copy link
Contributor

matsduf commented Sep 9, 2019

The bug is also covered by #84.

@matsduf
Copy link
Contributor

matsduf commented Oct 10, 2019

PR #85 will resolve this issue.

@sandoche2k
Copy link

@matsduf why the issue is not closed?

@mattias-p
Copy link
Member Author

@sandoche2k I forgot to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-High Priority: Issue to be solved before other T-Bug Type: Bug in software or error in test case description
Projects
None yet
Development

No branches or pull requests

3 participants