Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/netldns.t fails #9

Closed
matsduf opened this issue Feb 14, 2017 · 6 comments · Fixed by #11
Closed

t/netldns.t fails #9

matsduf opened this issue Feb 14, 2017 · 6 comments · Fixed by #11
Labels
T-Bug Type: Bug in software or error in test case description

Comments

@matsduf
Copy link
Contributor

matsduf commented Feb 14, 2017

The unit test makes assumptions on the DNS data that is no longer true. When running the test:

t/netldns.t ........ 1/? 
#   Failed test 'nine authority'
#   at t/netldns.t line 81.
#          got: '10'
#     expected: '9'
# Looks like you failed 1 test of 86.
t/netldns.t ........ Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/86 subtests 

Clean the unit tests from too detailed assumptions.

@matsduf matsduf added the T-Bug Type: Bug in software or error in test case description label Feb 14, 2017
@matsduf
Copy link
Contributor Author

matsduf commented Mar 8, 2017

Work-around until fixed:

cpanm -n Net::LDNS
The '-n' flag is allowing it to build by skipping the tests.

Or:

cpan -f -i Net::LDNS
Force installation even though there are problems.

@aabdnn
Copy link

aabdnn commented Mar 8, 2017

Hi @matsduf. I'm already using '-n' in our build process to skip tests, until this issue is fixed.

@matsduf
Copy link
Contributor Author

matsduf commented Mar 8, 2017

@aabdnn, we had another user with the same problem, and I got the work-around from a mail from you. :-)

@aabdnn
Copy link

aabdnn commented May 29, 2017

This doesn't look like a proper fix. It's just a patch to make this work again for now. If .SE's name servers change, this test will fail again!

@mattias-p
Copy link
Member

@aabdnn I completely agree with you. This fix is just a stopgap. Properly fixing this is covered by #1.

@aabdnn
Copy link

aabdnn commented May 30, 2017

Thanks @mattias-p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Bug Type: Bug in software or error in test case description
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants