Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS no longer supported? #96

Closed
cdybedahl opened this issue Nov 19, 2019 · 5 comments
Closed

macOS no longer supported? #96

cdybedahl opened this issue Nov 19, 2019 · 5 comments
Assignees
@mattias-p
Labels
P-High Priority: Issue to be solved before other T-Question Type: Incoming question
Milestone
v2020.1

Comments

@cdybedahl
Copy link
Contributor

Commit fbc6808 removes the ability to build the module on macOS. If this wasn't intentional, please fix. If it was intentional, please document.
@matsduf
Copy link
Contributor

matsduf commented Nov 20, 2019

The commit belongs to PR #44 which is documented in issue #43. It was not intentional to remove support for MacOS, but the parameters were not documented and MacOS is not one of the OSs that the project officially support so we have not seen the issue.

If you can provide a PR of needed changes to make it work under MacOS including documentation of use and purpose we should be able to included it given that those changes are compatible with the OSs that we do support.

@matsduf matsduf added A-BuildSystem T-Question Type: Incoming question labels Nov 21, 2019
@matsduf
Copy link
Contributor

matsduf commented Nov 29, 2019

@cdybedahl, any comment on your side?

@matsduf
Copy link
Contributor

matsduf commented Mar 20, 2020

@cdybedahl, do you have more information or can we close this issue?

@matsduf matsduf added this to the v2019.2 milestone Mar 20, 2020
@matsduf matsduf self-assigned this Mar 20, 2020
@sandoche2k sandoche2k modified the milestones: v2019.2, v2020.1 Mar 23, 2020
@matsduf matsduf assigned mattias-p and unassigned matsduf May 28, 2020
@matsduf matsduf added the P-High Priority: Issue to be solved before other label May 28, 2020
@matsduf
Copy link
Contributor

matsduf commented Sep 14, 2020

We welcome a pull request to resolve this issue, but we cannot fix it within the team. We close this issue.

@matsduf matsduf closed this as completed Sep 14, 2020
@matsduf
Copy link
Contributor

matsduf commented Dec 9, 2021

Zonemaster-CLI is now supported on Docker, and it works on both MacOS and Windows.

@ghost ghost mentioned this issue Mar 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattias-p mattias-p

Labels
P-High Priority: Issue to be solved before other T-Question Type: Incoming question
Projects
None yet
Milestone
v2020.1
Development

No branches or pull requests
4 participants
@cdybedahl @mattias-p @matsduf @sandoche2k