From f11e96053729611cddc0f9c176444581abf544cc Mon Sep 17 00:00:00 2001 From: Anders Kaseorg Date: Mon, 13 Nov 2023 13:36:56 -0800 Subject: [PATCH] Add more uses of @override. Signed-off-by: Anders Kaseorg --- zulip_bots/zulip_bots/bots/beeminder/test_beeminder.py | 2 ++ zulip_bots/zulip_bots/bots/flock/test_flock.py | 2 ++ .../zulip_bots/bots/game_of_fifteen/test_game_of_fifteen.py | 3 +++ zulip_bots/zulip_bots/bots/jira/test_jira.py | 4 +++- zulip_bots/zulip_bots/bots/merels/merels.py | 3 +++ zulip_bots/zulip_bots/bots/twitpost/test_twitpost.py | 4 ++++ 6 files changed, 17 insertions(+), 1 deletion(-) diff --git a/zulip_bots/zulip_bots/bots/beeminder/test_beeminder.py b/zulip_bots/zulip_bots/bots/beeminder/test_beeminder.py index bcd598ab7..2095ff457 100644 --- a/zulip_bots/zulip_bots/bots/beeminder/test_beeminder.py +++ b/zulip_bots/zulip_bots/bots/beeminder/test_beeminder.py @@ -2,6 +2,7 @@ from unittest.mock import patch from requests.exceptions import ConnectionError +from typing_extensions import override from zulip_bots.test_file_utils import get_bot_message_handler from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler @@ -21,6 +22,7 @@ class TestBeeminderBot(BotTestCase, DefaultTests): \n* `comment`**:** Add a comment [**NOTE:** Optional field, default is *None*]\ """ + @override def test_bot_responds_to_empty_message(self) -> None: with self.mock_config_info(self.normal_config), self.mock_http_conversation( "test_valid_auth_token" diff --git a/zulip_bots/zulip_bots/bots/flock/test_flock.py b/zulip_bots/zulip_bots/bots/flock/test_flock.py index 92058907c..2f198105f 100644 --- a/zulip_bots/zulip_bots/bots/flock/test_flock.py +++ b/zulip_bots/zulip_bots/bots/flock/test_flock.py @@ -2,6 +2,7 @@ from unittest.mock import patch from requests.exceptions import ConnectionError +from typing_extensions import override from zulip_bots.test_lib import BotTestCase, DefaultTests @@ -17,6 +18,7 @@ class TestFlockBot(BotTestCase, DefaultTests): *Syntax*: **@botname to: message** where `to` is **firstName** of recipient. """ + @override def test_bot_responds_to_empty_message(self) -> None: self.verify_reply("", self.help_message) diff --git a/zulip_bots/zulip_bots/bots/game_of_fifteen/test_game_of_fifteen.py b/zulip_bots/zulip_bots/bots/game_of_fifteen/test_game_of_fifteen.py index fc03db798..687f0e718 100644 --- a/zulip_bots/zulip_bots/bots/game_of_fifteen/test_game_of_fifteen.py +++ b/zulip_bots/zulip_bots/bots/game_of_fifteen/test_game_of_fifteen.py @@ -1,5 +1,7 @@ from typing import Dict, Final, List, Tuple +from typing_extensions import override + from zulip_bots.bots.game_of_fifteen.game_of_fifteen import GameOfFifteenModel from zulip_bots.game_handler import BadMoveError from zulip_bots.test_lib import BotTestCase, DefaultTests @@ -8,6 +10,7 @@ class TestGameOfFifteenBot(BotTestCase, DefaultTests): bot_name = "game_of_fifteen" + @override def make_request_message( self, content: str, user: str = "foo@example.com", user_name: str = "foo" ) -> Dict[str, str]: diff --git a/zulip_bots/zulip_bots/bots/jira/test_jira.py b/zulip_bots/zulip_bots/bots/jira/test_jira.py index 4f0f947c1..5ccd3ddb1 100644 --- a/zulip_bots/zulip_bots/bots/jira/test_jira.py +++ b/zulip_bots/zulip_bots/bots/jira/test_jira.py @@ -1,5 +1,7 @@ from typing import Final +from typing_extensions import override + from zulip_bots.test_lib import BotTestCase, DefaultTests @@ -260,7 +262,7 @@ def test_help(self) -> None: with self.mock_config_info(self.MOCK_CONFIG_INFO): self.verify_reply("help", self.MOCK_HELP_RESPONSE) - # This overrides the default one in `BotTestCase`. + @override def test_bot_responds_to_empty_message(self) -> None: with self.mock_config_info(self.MOCK_CONFIG_INFO): self.verify_reply("", self.MOCK_NOTHING_RESPONSE) diff --git a/zulip_bots/zulip_bots/bots/merels/merels.py b/zulip_bots/zulip_bots/bots/merels/merels.py index 6d2e9c0ec..e2c28e251 100644 --- a/zulip_bots/zulip_bots/bots/merels/merels.py +++ b/zulip_bots/zulip_bots/bots/merels/merels.py @@ -1,5 +1,7 @@ from typing import Any, Final, List +from typing_extensions import override + from zulip_bots.game_handler import GameAdapter, SamePlayerMoveError from .libraries import database, game, game_data, mechanics @@ -76,6 +78,7 @@ class MerelsHandler(GameAdapter): "description": "Lets you play merels against any player.", } + @override def usage(self) -> str: return game.get_info() diff --git a/zulip_bots/zulip_bots/bots/twitpost/test_twitpost.py b/zulip_bots/zulip_bots/bots/twitpost/test_twitpost.py index 5161e172e..cbb8ca854 100644 --- a/zulip_bots/zulip_bots/bots/twitpost/test_twitpost.py +++ b/zulip_bots/zulip_bots/bots/twitpost/test_twitpost.py @@ -1,6 +1,8 @@ from typing import Final from unittest.mock import patch +from typing_extensions import override + from zulip_bots.test_file_utils import get_bot_message_handler, read_bot_fixture_data from zulip_bots.test_lib import BotTestCase, DefaultTests, StubBotHandler @@ -15,6 +17,7 @@ class TestTwitpostBot(BotTestCase, DefaultTests): } api_response = read_bot_fixture_data("twitpost", "api_response") + @override def test_bot_usage(self) -> None: bot = get_bot_message_handler(self.bot_name) bot_handler = StubBotHandler() @@ -24,6 +27,7 @@ def test_bot_usage(self) -> None: self.assertIn("This bot posts on twitter from zulip chat itself", bot.usage()) + @override def test_bot_responds_to_empty_message(self) -> None: with self.mock_config_info(self.mock_config): self.verify_reply("", "Please check help for usage.")