Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network graph filters get bypassed whenever you click on an empty part of the graph #3126

Open
2 of 3 tasks
darkbasic opened this issue Jun 6, 2023 · 8 comments
Open
2 of 3 tasks
Labels
bug Something isn't working no-stale

Comments

@darkbasic
Copy link
Contributor

Checklist

  • I am not using Home Assistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog and my problem is not mentioned there.

Deploy method

Docker

Z-Wave JS UI version

8.18.0

ZwaveJS version

10.23.1

Describe the bug

Whenever you set locations or node filters in the network graph they filter out all non matching nodes:

image

Unfortunately as soon as you click on an empty part of the network graph the filters get automatically bypassed and the whole graph gets displayed:

image

To Reproduce

Open zwavejs-ui in Home Assistant and go to the Network Graph, set a filter (location or node) and then click on an empty part of the graph.

Expected behavior

Filters should always be respected unless you explicitly disable them.

Additional context

The browser is Chromium and the screen resolution is 2560x1440, OS is Gentoo Linux ppc64le (Raptor CS Talos 2).

@darkbasic darkbasic added the bug Something isn't working label Jun 6, 2023
@robertsLando
Copy link
Member

This is expected otherwise when a filter is set you have no way to switch back to overview, a change on filters will re-apply them

@darkbasic
Copy link
Contributor Author

darkbasic commented Jun 6, 2023

In my opinion the overview should be filtered when filters are enabled, it makes no sense to have it unfiltered: if I filter by location and I click on a node it shows just node, but when clicking on an empty part of the graph I expect to switch back to that location nodes, not ALL the nodes in my network.
I suggest to make that change and add a switch to bypass filters, so you have a way to display all the nodes without having to remove the filters.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label

@duylong
Copy link

duylong commented Sep 6, 2024

Same problem, I thought it was a bug, apparently not.

I filter by room, I click on a node, how do I go back without clicking on an empty area of ​​the graph?

And I also agree, as long as the filter is selected, it should stay in that filter.

@darkbasic
Copy link
Contributor Author

Yeah it's definitely a bug in my opinion and I even tried to get it fixed myself lately, but I couldn't find a way to connect my local development frontend to the remote zwave-js-ui backend because the HASSIO docker container doesn't expose the port to the host. I did quite a lot of work with vue3 + vuetify lately but unfortunately I noticed that the codebase is still vue2: hopefully it won't be too big of a difference.

@robertsLando
Copy link
Member

@darkbasic the vuetify 3 switch is on my TODOs but requires lot of work, reason why I didn't do it already is just because vuetify was far from being so till few months ago

@darkbasic
Copy link
Contributor Author

darkbasic commented Sep 9, 2024

Yeah even now it's barely usable in production due to several missing key components. Most of them fortunately are available in Labs while others are easy enough to implement with some CSS tricks like the Material Sidesheet. That being said I love using latest Vuetify with vue3 and I think it's mature enough to begin transitioning.

@darkbasic
Copy link
Contributor Author

If someone else is interested here is my PR to develop against an Ingress zwave-js-ui instance: #3892

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-stale
Projects
None yet
Development

No branches or pull requests

3 participants