-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network graph filters get bypassed whenever you click on an empty part of the graph #3126
Comments
This is expected otherwise when a filter is set you have no way to switch back to overview, a change on filters will re-apply them |
In my opinion the overview should be filtered when filters are enabled, it makes no sense to have it unfiltered: if I filter by location and I click on a node it shows just node, but when clicking on an empty part of the graph I expect to switch back to that location nodes, not ALL the nodes in my network. |
This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label |
Same problem, I thought it was a bug, apparently not. I filter by room, I click on a node, how do I go back without clicking on an empty area of the graph? And I also agree, as long as the filter is selected, it should stay in that filter. |
Yeah it's definitely a bug in my opinion and I even tried to get it fixed myself lately, but I couldn't find a way to connect my local development frontend to the remote zwave-js-ui backend because the HASSIO docker container doesn't expose the port to the host. I did quite a lot of work with vue3 + vuetify lately but unfortunately I noticed that the codebase is still vue2: hopefully it won't be too big of a difference. |
@darkbasic the vuetify 3 switch is on my TODOs but requires lot of work, reason why I didn't do it already is just because vuetify was far from being so till few months ago |
Yeah even now it's barely usable in production due to several missing key components. Most of them fortunately are available in Labs while others are easy enough to implement with some CSS tricks like the Material Sidesheet. That being said I love using latest Vuetify with vue3 and I think it's mature enough to begin transitioning. |
If someone else is interested here is my PR to develop against an Ingress zwave-js-ui instance: #3892 |
Checklist
Deploy method
Docker
Z-Wave JS UI version
8.18.0
ZwaveJS version
10.23.1
Describe the bug
Whenever you set locations or node filters in the network graph they filter out all non matching nodes:
Unfortunately as soon as you click on an empty part of the network graph the filters get automatically bypassed and the whole graph gets displayed:
To Reproduce
Open zwavejs-ui in Home Assistant and go to the Network Graph, set a filter (location or node) and then click on an empty part of the graph.
Expected behavior
Filters should always be respected unless you explicitly disable them.
Additional context
The browser is Chromium and the screen resolution is 2560x1440, OS is Gentoo Linux ppc64le (Raptor CS Talos 2).
The text was updated successfully, but these errors were encountered: