{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":811534463,"defaultBranch":"main","name":"aws-otel-python-instrumentation-public","ownerLogin":"zzhlogin","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-06-06T19:33:37.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/146124015?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1717710000.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"166c4cb36da6634cb070df5a312a62f6b0136a9c","ref":"refs/heads/test_branch","pushedAt":"2024-06-06T21:40:00.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"zzhlogin","name":null,"path":"/zzhlogin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/146124015?s=80&v=4"},"commit":{"message":"Fix Flaky Test in AWS X-Ray Remote Sampler Client Test (#201)\n\n*Issue #, if available:*\r\nThis PR fixes flaky test `test_urls_excluded_from_sampling`, causing\r\nissues in PR workflows\r\n- Example:\r\nhttps://github.com/aws-observability/aws-otel-python-instrumentation/actions/runs/9103811387/job/25026448867\r\n \r\nInstantiation of `AwsXRayRemoteSampler` will spawn processes that will\r\nregularly (every 10s and 300s) make a Request call, and these processes\r\nstay alive between different unit tests. This means that the test that\r\ncounts the number instrumented Request calls is affected by these\r\n\"orphaned\" processes.\r\n\r\nThe solution is to stop these processes inside the tests that they are\r\ncreated from, or stop them from being spawned in the first place if they\r\nare not needed.\r\n\r\n*Description of changes:*\r\n- Stop the daemon rule and target poller processes inside the tests that\r\nthey are created from, or stop them from being spawned in the first\r\nplace if they are not needed.\r\n- Revert previous fix attempt\r\n- Add test for version to increase and pass code coverage\r\n\r\n*Testing:*\r\n- Reproduced failing test by running test in loop of 10000 runs\r\n- Failing test not reproducible after applying fix.\r\n\r\nBy submitting this pull request, I confirm that you can use, modify,\r\ncopy, and redistribute this contribution, under the terms of your\r\nchoice.","shortMessageHtmlLink":"Fix Flaky Test in AWS X-Ray Remote Sampler Client Test (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2334521000\" data-permission-text=\"Title is private\" data-url=\"https://github.com/aws-observability/aws-otel-python-instrumentation/issues/201\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/aws-observability/aws-otel-python-instrumentation/pull/201/hovercard\" href=\"https://github.com/aws-observability/aws-otel-python-instrumentation/pull/201\">aws-observabi…</a>"}},{"before":null,"after":"166c4cb36da6634cb070df5a312a62f6b0136a9c","ref":"refs/heads/delete-commit","pushedAt":"2024-06-06T19:35:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"zzhlogin","name":null,"path":"/zzhlogin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/146124015?s=80&v=4"},"commit":{"message":"Fix Flaky Test in AWS X-Ray Remote Sampler Client Test (#201)\n\n*Issue #, if available:*\r\nThis PR fixes flaky test `test_urls_excluded_from_sampling`, causing\r\nissues in PR workflows\r\n- Example:\r\nhttps://github.com/aws-observability/aws-otel-python-instrumentation/actions/runs/9103811387/job/25026448867\r\n \r\nInstantiation of `AwsXRayRemoteSampler` will spawn processes that will\r\nregularly (every 10s and 300s) make a Request call, and these processes\r\nstay alive between different unit tests. This means that the test that\r\ncounts the number instrumented Request calls is affected by these\r\n\"orphaned\" processes.\r\n\r\nThe solution is to stop these processes inside the tests that they are\r\ncreated from, or stop them from being spawned in the first place if they\r\nare not needed.\r\n\r\n*Description of changes:*\r\n- Stop the daemon rule and target poller processes inside the tests that\r\nthey are created from, or stop them from being spawned in the first\r\nplace if they are not needed.\r\n- Revert previous fix attempt\r\n- Add test for version to increase and pass code coverage\r\n\r\n*Testing:*\r\n- Reproduced failing test by running test in loop of 10000 runs\r\n- Failing test not reproducible after applying fix.\r\n\r\nBy submitting this pull request, I confirm that you can use, modify,\r\ncopy, and redistribute this contribution, under the terms of your\r\nchoice.","shortMessageHtmlLink":"Fix Flaky Test in AWS X-Ray Remote Sampler Client Test (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2334521000\" data-permission-text=\"Title is private\" data-url=\"https://github.com/aws-observability/aws-otel-python-instrumentation/issues/201\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/aws-observability/aws-otel-python-instrumentation/pull/201/hovercard\" href=\"https://github.com/aws-observability/aws-otel-python-instrumentation/pull/201\">aws-observabi…</a>"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNi0wNlQyMTo0MDowMC4wMDAwMDBazwAAAARepEr6","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNi0wNlQyMTo0MDowMC4wMDAwMDBazwAAAARepEr6","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNi0wNlQxOTozNTo0Ny4wMDAwMDBazwAAAARejlYK"}},"title":"Activity · zzhlogin/aws-otel-python-instrumentation-public"}